Fix process kill on windows #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't get outs nor errs from Popen.communicate() Fixes sylikc#63
OdyX
force-pushed
the
fix-process-kill-on-windows
branch
from
e334483 to
205364f
Compare
|
@OdyX while this fixes the actual hanging, it leaves zombie processes of the exiftool launcher on Windows. See https://oliverbetz.de/pages/Artikel/ExifTool-for-Windows to understand what the default self-extracting Perl Packager does. I recall trying this fix before, but I've opted not to just kill as it leaves the zombie launcher around. CPython really needs to fix that bug... but it doesn't seem to be high priority if it's been open so long :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63 AFAIK